Skip to content

Revert ChoiceGroup change in 5.0 to minimize potential partner impact.#4962

Merged
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:revert-choicegroup
May 23, 2018
Merged

Revert ChoiceGroup change in 5.0 to minimize potential partner impact.#4962
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:revert-choicegroup

Conversation

@dzearing
Copy link
Copy Markdown
Member

@dzearing dzearing commented May 23, 2018

There was a particular bug in the ChoiceGroup:

The props.options passed in was being mutated by the ChoiceGroup. This violates principles of React components (don't modify input!)

We fixed this issue in the recently merged ChoiceGroup styling PR, but realized this might be a breaking change for partners.

We'd like to revert in 5.0 (it was just published a few hours ago, so reverting quickly) and re-target for 6.0 to avoid potential partner friction. Sorry for the trouble.

@dzearing dzearing requested a review from srideshpande as a code owner May 23, 2018 14:55
@dzearing dzearing merged commit 17547b3 into microsoft:master May 23, 2018
@dzearing dzearing deleted the revert-choicegroup branch May 23, 2018 15:25
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request May 23, 2018
* master: (67 commits)
  Applying package updates.
  Revert ChoiceGroup change in 5.0 to minimize potential partner impact. (microsoft#4962)
  Applying package updates.
  ChoiceGroup: getStyles conversion (microsoft#4852)
  Export SASS variables and mixins (microsoft#4959)
  Variants: update algorithm (microsoft#4949)
  Allow for customization of keycodes that cause the focus rect to appear (microsoft#4948)
  Mergestyles facepile (microsoft#4950)
  Fixing circular dependency and non-AMD references in ContextualMenu (microsoft#4946)
  Clean up semantic slots (microsoft#4932)
  Added missing merge-styles background-size typing (microsoft#4935)
  Applying package updates.
  Split menu button styles (microsoft#4922)
  Experimental Chiclet Component (microsoft#4678)
  Remove hover and pressed background colors (microsoft#4908)
  Remove @cschleiden as Rating code owner (microsoft#4929)
  Addressing Issue microsoft#3691 - SplitButton: In Safari, the SplitButton has mismatched heights (microsoft#4797)
  Applying package updates.
  Adding option for focus on tags in disabled picker (microsoft#4833)
  Jest merge-styles serialization fix for animation-name (microsoft#4927)
  ...
Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request May 29, 2018
* master: (85 commits)
  Applying package updates.
  Shimmer: refactor in preparation for migration to OUFR (microsoft#4958)
  Applying package updates.
  Theming: fix error colors (microsoft#4969)
  MaskedTextField: Added event callback passthrough (microsoft#4956)
  Experiments/Nav component: Enable auto expand until the next manual expand disables the auto expand (microsoft#4996)
  Applying package updates.
  Experiments/Nav component: Auto select/expand based on the selectedKey prop (microsoft#4984)
  StickyPane: fix Array.from in Ie (microsoft#4982)
  ContextualMenu has aria-labelledBy referencing element not in DOM (microsoft#4963)
  Keyboard support for the slim version of experiments/Nav component and added aria attributes (microsoft#4981)
  Move ghdocs to wiki (microsoft#4977)
  Remove build artifacts (microsoft#4976)
  Revisited the Multi-select Combo box initial state selection fix (microsoft#4884)
  Applying package updates.
  readme cleanup (microsoft#4972)
  Theming: add the bodyBackgroundDarker semantic slot (microsoft#4957)
  Improvements for auto-select opt-in mode (microsoft#4914)
  Applying package updates.
  Revert ChoiceGroup change in 5.0 to minimize potential partner impact. (microsoft#4962)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant